+- MFGG Forums (https://forums.mfgg.net)
+-- Forum: MFGG (https://forums.mfgg.net/forumdisplay.php?fid=4)
+--- Forum: Suggestions (https://forums.mfgg.net/forumdisplay.php?fid=11)
+---- Forum: Resolved Suggestions (https://forums.mfgg.net/forumdisplay.php?fid=19)
+---- Thread: DONE Broken image cleanup (/showthread.php?tid=1686)
Broken image cleanup - VinnyVideo - 03-10-2019
A few unimportant images weren't showing up in the User Control Panel and on the forum display.
Specifically:
- The paperclip icon that shows whether a topic contains an attachment (there are some here
- The icon that shows whether a buddy is online or not (example here
- The icon that you need to click should you feel heartless enough to delete one of your buddies (same as previous link)
The templates expected each skin to have its own version of these images, but these images didn't exist in the skin image folders - instead, they only existed in the main /images/ folder. So I went into the usercp_editlists_user and forumdisplay_thread_attachment_count templates and changed the paths to the main images directory. For example:
Old code:
Code:
img src="{$theme['imgdir']}/buddy_{$status}.png"New code:
Code:
img src="images/buddy_{$status}.png"You could argue that we don't need these default icons at all, or that it would be better to make a custom image (or even skin-specific images). If so, that's fine. But this is a starting point - we should always fix broken images.
Please let me know if you find any other images that aren't working right.