MFGG Forums
SOLVED Fix the average scores in the hacks section - Printable Version

+- MFGG Forums (https://forums.mfgg.net)
+-- Forum: MFGG (https://forums.mfgg.net/forumdisplay.php?fid=4)
+--- Forum: Suggestions (https://forums.mfgg.net/forumdisplay.php?fid=11)
+---- Forum: Resolved Suggestions (https://forums.mfgg.net/forumdisplay.php?fid=19)
+---- Thread: SOLVED Fix the average scores in the hacks section (/showthread.php?tid=3158)



Fix the average scores in the hacks section - Q-Nova - 07-21-2024

If you filter the hacks section by score, you'd see that only one hack has a score. A couple other hacks, however, have a review, such as SMW: Not Over Yet... and yet their average score is blanked out. It should be fixable, although I'm not sure how easy that is to do. It would give people more incentive to write reviews for hacks.


RE: Fix the average scores in the hacks section - VinnyVideo - 07-22-2024

Should be fixed now! I updated the script that recalculates average review scores to include the hacks section.

Let me know if you run into any issues.


RE: Fix the average scores in the hacks section - Q-Nova - 07-23-2024

Yes! It works now! Thank you, @VinnyVideo! That problem has always bugged me! I played around with the site for a bit (selecting different filters and checking other pages), and I notice zero problems so far!


RE: Fix the average scores in the hacks section - Q-Nova - 07-25-2024

@VinnyVideo For some reason, Yoshi vs Windows Platinum has the average score blanked out despite having like over 10 or 20 reviews. You might want to look into that.


RE: Fix the average scores in the hacks section - VinnyVideo - 07-26-2024

It seems like a lot of older games have missing review scores, and running the script to recalculate review scores isn't fixing the issue. I tried removing the code change I made for adding hacks, but that didn't fix anything.

I can't find any rhyme or reason as to why some games have missing review scores while others don't. I also don't know how long this issue has been occurring.

I'm no PHP wizard, unfortunately, so it's possible the answer is hiding in plain sight. I'll keep this topic marked as WIP.


RE: Fix the average scores in the hacks section - Q-Nova - 07-28-2024

@VinnyVideo Until your post, I didn't notice that other old games were getting screwed up scores! That's weird! From what I've seen, it seems to only apply to games made in 2004 and earlier. While it's easy to notice that many games are missing scores all of a sudden, there are also some games that have wildly inaccurate scores (Mario Mini Game Madness is a hilarious example, as you might've seen, and there's also Yoshi's Ghost Run and Mario's Mansion 3).

I think the bug started happening some point in this month. On the first day, I posted a comment on Mario Breakout, and I'm pretty certain that it had a low score at the time (it's now blank). No clue on what the root of it is, though. Could it be an overflow? Maybe something needs to be updated? Just throwing a couple guesses; I'm not really a PHP wizard either. Hm, weren't you looking into the issue of certain submissions not appearing in the news updates? Did any of you tinker with the code at the time? If so, maybe that's where the problem is?


RE: Fix the average scores in the hacks section - VinnyVideo - 05-18-2025

This should be fixed now! All games and hacks should have correct review scores now. Let me know if anything's out of whack.

The latest code is live in production and is also viewable on our GitHub if you're interested.